fix wrong quotes around inline codes#6523
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
|
I think no need to merge this PR, let's wait to fix it in the upstream package silvenon/remark-smartypants#80 |
|
@dimaMachina Yes, It's merging in no time. I will just change this PR to update dependency once new version releases 😋 |
|
@dimaMachina I just found it they don't rely on |
|
@2wheeh thank you of course you can refer 👍 |
2wheeh
force-pushed
the
quotes-around-code
branch
from
c000cda to
207cde1
Compare
2wheeh
force-pushed
the
quotes-around-code
branch
from
207cde1 to
2f2ad86
Compare
|
@2wheeh thanks for fixing this! I'm still seeing it broken in the preview deployment, could you take a look? 
|
@rickhanlonii Have you checked they are cached ? 
-> captured from preview deployment building logs.
|
|
Ah, can you increment the cache key here: https://github.com/reactjs/react.dev/blob/main/src/utils/prepareMDX.js#L10 |
@rickhanlonii done it: 1c6d531 except in search bar : |
|
Awesome, thanks! The search should update the index after deploy. |
4 participants
related:
The root cause is fixing onremark-smartypants: hereBut It's hard to tell when it gets merged so in the meanwhile this typo fix can be helpful.
Edit: The codes seemed to be referred to
silvenon/remark-smartypantsbut we are not depending on that package. They resolved same issue recently so I utilize their fixes in this PR.after: